[Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

[Lawrence D'Anna via Phabricator via lldb-commits]

lawrence_danna marked an inline comment as done.
lawrence_danna added inline comments.


================
Comment at: lldb/scripts/Python/python-wrapper.swig:64
 
+    unsigned max_positional_args = PythonCallable::ArgInfo::UNBOUNDED;
+    if (auto arg_info = pfunc.GetArgInfo()) {
----------------
labath wrote:
> Is there any case where fetching the argument info will fail, but we still can successfully call the target object? Should we just bail out here?
probably not?     My thinking is that since there's no meaningful way to return an error from this function we may as well try to call it and let the exception get logged.   But I dunno.    Should I change it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69468/new/

https://reviews.llvm.org/D69468