[Lldb-commits] [lldb] 10b5cd8 - [LLDB] Fix inline variable only used in assertion. (NFC)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 25 15:47:27 PDT 2019


Author: Jonas Devlieghere
Date: 2019-10-25T15:47:17-07:00
New Revision: 10b5cd8ed5272d135ac75a94d3cf5854a0912f84

URL: https://github.com/llvm/llvm-project/commit/10b5cd8ed5272d135ac75a94d3cf5854a0912f84
DIFF: https://github.com/llvm/llvm-project/commit/10b5cd8ed5272d135ac75a94d3cf5854a0912f84.diff

LOG: [LLDB] Fix inline variable only used in assertion. (NFC)

This prevents unused variable warning/error in -DNDEBUG builds. The
variable was introduced in 5934cd11ea3e.

Patch by: Shu-Chun Weng

Differential revision: https://reviews.llvm.org/D69451

Added: 
    

Modified: 
    lldb/utils/TableGen/LLDBPropertyDefEmitter.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/utils/TableGen/LLDBPropertyDefEmitter.cpp b/lldb/utils/TableGen/LLDBPropertyDefEmitter.cpp
index 51c15a715f38..f36deeebf906 100644
--- a/lldb/utils/TableGen/LLDBPropertyDefEmitter.cpp
+++ b/lldb/utils/TableGen/LLDBPropertyDefEmitter.cpp
@@ -46,7 +46,6 @@ static void emitProperty(Record *Property, raw_ostream &OS) {
   bool hasDefaultUnsignedValue = Property->getValue("HasDefaultUnsignedValue");
   bool hasDefaultEnumValue = Property->getValue("HasDefaultEnumValue");
   bool hasDefaultStringValue = Property->getValue("HasDefaultStringValue");
-  bool hasDefaultBooleanValue = Property->getValue("HasDefaultBooleanValue");
 
   // Guarantee that every property has a default value.
   assert((hasDefaultUnsignedValue || hasDefaultEnumValue ||
@@ -60,7 +59,7 @@ static void emitProperty(Record *Property, raw_ostream &OS) {
 
   // Guarantee that every boolean property has a boolean default value.
   assert(!(Property->getValueAsString("Type") == "Boolean" &&
-           !hasDefaultBooleanValue) &&
+           !Property->getValue("HasDefaultBooleanValue")) &&
          "Boolean property must have a boolean default value.");
 
   // Guarantee that every string property has a string default value.


        


More information about the lldb-commits mailing list