[Lldb-commits] [PATCH] D69210: [Disassembler] Simplify MCInst predicates

Vedant Kumar via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 24 13:50:07 PDT 2019


vsk added a comment.

I don't think it should be necessary to read the class in its entirety to understand when `m_opcode` is safe to use. However, as I'm not sure how the disassembler is called in to, I don't think it's a good idea to refactor the whole thing right away.

Let's start with this simple change to drop some redundant code, and maybe revisit things later?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69210/new/

https://reviews.llvm.org/D69210





More information about the lldb-commits mailing list