[Lldb-commits] [PATCH] D67793: new api class: SBFile

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/trunk/source/Host/common/File.cpp:74
+      .Case("r", File::eOpenOptionRead)
+      .Case("w", File::eOpenOptionWrite)
+      .Case("a", File::eOpenOptionWrite | File::eOpenOptionAppend |
----------------
mgorny wrote:
> Shouldn't this also include `File::eOpenOptionCanCreate | File::eOpenOptionTruncate`?
Yeah, I guess it should, though it probably does not matter in practice right now as we're only using this on already opened FILE* objects.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67793/new/

https://reviews.llvm.org/D67793