[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I'm sorry, this dropped off my radar. The code looks fine, but it could use some more tests. For instance, one test when you set the setting value to the non-default , and then check that lldb does _not_ use the `g` packet .



================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td:23
+    DefaultFalse,
+    Desc<"Specify if the server should use 'g' packets to write registers.">;
 }
----------------
Having a capital G in the setting name would be somewhat unprecedented (though I wouldn't be really opposed to it), but I think that at least the description should say 'G'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62931/new/

https://reviews.llvm.org/D62931