[Lldb-commits] [lldb] d01fd2f - [lldb] Add nodebug attribute to import-std-module/sysroot test

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 23 09:30:23 PDT 2019


Author: Raphael Isemann
Date: 2019-10-23T09:26:57-07:00
New Revision: d01fd2f35a02cb53a5d9d1a5342b5085c5dce66c

URL: https://github.com/llvm/llvm-project/commit/d01fd2f35a02cb53a5d9d1a5342b5085c5dce66c
DIFF: https://github.com/llvm/llvm-project/commit/d01fd2f35a02cb53a5d9d1a5342b5085c5dce66c.diff

LOG: [lldb] Add nodebug attribute to import-std-module/sysroot test

Summary:
So far we rely on the default argument and the fact that we don't call this
inline function in our actual `main.cpp` to make sure that this function can only
be called if LLDB loads this header as a C++ module. This patch just adds
the nodebug attribute as yet another measure to make sure LLDB can't call this
function without the standard module loaded. Note that the test is already
requiring clang for the sysroot setup, so its fine that this is a Clang specific attribute.

Reviewers: friss, labath

Subscribers: JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D68861

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/commands/expression/import-std-module/sysroot/root/usr/include/c++/v1/algorithm

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/commands/expression/import-std-module/sysroot/root/usr/include/c++/v1/algorithm b/lldb/packages/Python/lldbsuite/test/commands/expression/import-std-module/sysroot/root/usr/include/c++/v1/algorithm
index 43f7becdbeb6..a0cb2f15a193 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/expression/import-std-module/sysroot/root/usr/include/c++/v1/algorithm
+++ b/lldb/packages/Python/lldbsuite/test/commands/expression/import-std-module/sysroot/root/usr/include/c++/v1/algorithm
@@ -4,6 +4,7 @@ namespace std {
   // Makes sure we get a support file for this header.
   struct vector { int i; };
 
+  __attribute__((__nodebug__))
   inline int myabs(int i = -123) {
     double nil;
     return i < 0 ? -i : i;


        


More information about the lldb-commits mailing list