[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

Lawrence D'Anna via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 22 12:49:09 PDT 2019


lawrence_danna added a comment.

In D68856#1718240 <https://reviews.llvm.org/D68856#1718240>, @mgorny wrote:

> In the meantime, I found the root issue. It's in `PythonDataObjects.cpp`, `PythonFile::ConvertToFile(bool borrowed)`. The function unconditionally calls `flush()` on the fd. However, it's invalid to call `flush()` on stdin or — more generally — on file open only for reading. I'm going to submit a patch in a few minutes.


🎉


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68856/new/

https://reviews.llvm.org/D68856





More information about the lldb-commits mailing list