[Lldb-commits] [PATCH] D69285: minidump: Rename some architecture constants

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: amccarth, clayborg.
Herald added subscribers: fedor.sergeev, hiraditya, kristof.beyls.
Herald added projects: LLDB, LLVM.

The architecture enum contains two kinds of contstants: the "official" ones
defined by Microsoft, and unofficial constants added by breakpad to cover the
architectures not described by the first ones.

Up until now, there was no big need to differentiate between the two. However,
now that Microsoft has defined
https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/ns-sysinfoapi-system_info
a constant for ARM64, we have a name clash.

This patch renames all breakpad-defined constants with to include the prefix
"BP_". This frees up the name "ARM64", which I'll re-introduce with the new
"official" value in a follow-up patch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69285

Files:
  lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
  llvm/include/llvm/BinaryFormat/MinidumpConstants.def
  llvm/lib/ObjectYAML/MinidumpYAML.cpp
  llvm/test/tools/obj2yaml/basic-minidump.yaml
  llvm/unittests/ObjectYAML/MinidumpYAMLTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69285.225971.patch
Type: text/x-patch
Size: 5203 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191021/a2b4b2d4/attachment.bin>