[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D68961#1717197 <https://reviews.llvm.org/D68961#1717197>, @shafik wrote:

> When the I added the feature to the front end tests were added to verify that `DW_AT_export_symbols` is being generated for anonymous structs in D66605 <https://reviews.llvm.org/D66605> and D66667 <https://reviews.llvm.org/D66667> so if this regresses in the front-end we will catch it vis these tests. So as far I can tell we have tests at every point it can regress.


But that's a test for clang. It will make sure it clang does stop emitting this attribute accidentally, but it will not help you if the removal is a conscious decision. At that point, the clang test will be deleted/modified too, but I doubt anyone will think of lldb and the fact that some part of lldb codebase becomes untested.

In fact, I think these patches illustrate very well the point I'm trying to make. D66667 <https://reviews.llvm.org/D66667> does not check that the attribute ends up in the debug info. It only adds a test to ensure that clang emits some llvm IR. It could test the actual dwarf, but it doesn't, because llvm has a strong preference for single-component unit tests. lldb's test suite is an exception in the llvm world in that nearly every lldb test is an end-to-end test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68961/new/

https://reviews.llvm.org/D68961