[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header
Adrian McCarthy via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Oct 21 13:45:51 PDT 2019
amccarth accepted this revision.
amccarth added a comment.
I'm OK with this. I'm just wondering whether it would be a good idea to make it clear that these header sections are "not considered to be a section in the strictest sense." Is the distinction going to be important to future code readers? Do we already have "sections" that aren't truly "sections"?
Perhaps just a comment where the header sections are created?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69100/new/
https://reviews.llvm.org/D69100
More information about the lldb-commits
mailing list