[Lldb-commits] [PATCH] D69210: [Disassembler] Simplify MCInst predicates

Vedant Kumar via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Oct 19 11:02:41 PDT 2019


vsk added a comment.

Hm, this patch is bugging me.

It looks a bit like instructions are still decoded multiple times in different ways (e.g. in the `Decode` and `CalculateMnemonicOperandsAndComment` methods, which both modify `m_opcode`). Any ideas on whether/how to consolidate these?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69210/new/

https://reviews.llvm.org/D69210





More information about the lldb-commits mailing list