[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

[Lawrence D'Anna via Phabricator via lldb-commits]

lawrence_danna added inline comments.


================
Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:401
 
-  void Reset(PyRefType type, PyObject *py_obj) {
-    Reset();
+  void Reset() { PythonObject::Reset(); }
+
----------------
labath wrote:
> Is this needed, given the "using" declaration above?
yes, it seems when you delete one override of a member function, it deletes all the other ones that you don't explicitly mention too.   Actually it's the using line that should be deleted.


================
Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:406
+  TypedPythonObject(PyRefType type, PyObject *py_obj) {
+    m_py_obj = nullptr;
     if (!py_obj)
----------------
labath wrote:
> Isn't this already set by the superclass constructor?
yes, fixed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69133/new/

https://reviews.llvm.org/D69133