[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D68130#1713620 <https://reviews.llvm.org/D68130#1713620>, @teemperor wrote:

> Yeah, seems like constructing objects in expressions isn't implemented on Windows. I'm not sure if there is a reliable way to test that constructors aren't shadowed by these global functions if constructors themselves don't work on Windows, but I filed llvm.org/pr43707 for the underlying bug and x-failed the tests. Will push in a few minutes.


Thanks!

Btw, I also see TestCallOverriddenMethod failing on Ubuntu but there's no official bot for that.

FAIL: test_call_on_temporary_dwarf (TestCallOverriddenMethod.ExprCommandCallOverriddenMethod)

  Test calls to overridden methods in derived classes.

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/e2admin/vstsdrive/_work/115/s/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1748, in test_method
    return attrvalue(self)
  File "/home/e2admin/vstsdrive/_work/115/s/lldb/packages/Python/lldbsuite/test/decorators.py", line 111, in wrapper
    func(*args, **kwargs)
  File "/home/e2admin/vstsdrive/_work/115/s/lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py", line 71, in test_call_on_temporary
    self.expect("expr Base().foo()", substrs=["1"])
  File "/home/e2admin/vstsdrive/_work/115/s/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2309, in expect
    inHistory=inHistory)
  File "/home/e2admin/vstsdrive/_work/115/s/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2068, in runCmd
    msg if (msg) else CMD_MSG(cmd))

AssertionError: False is not True : Command 'expr Base().foo()
Error output:
error: Execution was interrupted, reason: signal SIGABRT.
The process has been returned to the state before expression evaluation.
' returns successfully
Config=x86_64-/home/e2admin/vstsdrive/_work/115/b/bin/clang-10


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68130/new/

https://reviews.llvm.org/D68130