[Lldb-commits] [lldb] r375146 - [Reproducer] Surface error if setting the cwd fails

[Jonas Devlieghere via lldb-commits]

You're right. I've replaced it with rtrim in r375259.

On Fri, Oct 18, 2019 at 4:12 AM Pavel Labath <pavel at labath.sk> wrote:
>
> On 17/10/2019 19:58, Jonas Devlieghere via lldb-commits wrote:
> > +      cwd->erase(std::remove_if(cwd->begin(), cwd->end(), std::iscntrl),
> > +                 cwd->end());
>
> What is this hacking around? I can imagine a .rtrim() would be needed to
> remove a trailing cr/lf (though it would still be better and probably
> easy to just make sure the crlf is not added to the file), but this
> seems way over the top.
>
> Btw, control characters can appear in file/directory names on most posix
> systems.