[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

Fri Oct 18 06:35:34 PDT 2019

labath marked an inline comment as done.
labath added inline comments.

================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:800
         /*flags*/ 0);
+    header_sp->SetPermissions(ePermissionsReadable);
     m_sections_up->AddSection(header_sp);
----------------
labath wrote:
> Are these the right permissions for the header?
I've dug around in some minidumps I have around and this does appear to be correct. It looks like the entire block of memory for the object is first allocated with PAGE_EXECUTE_WRITE_COPY, and the permissions for the header region are later changed to PAGE_READ_ONLY.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69102/new/

https://reviews.llvm.org/D69102