[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

[Pavel Labath via Phabricator via lldb-commits]

labath marked 4 inline comments as done.
labath added inline comments.


================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:794
+    SectionSP header_sp = std::make_shared<Section>(
+        module_sp, this, ~user_id_t(0), ConstString("header"),
+        eSectionTypeOther, m_coff_header_opt.image_base,
----------------
clayborg wrote:
> maybe name this "COFF header" or "PECOFF header"?
good idea.


================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:797
+        m_coff_header_opt.header_size,
+        /*file_offset*/ 0, m_coff_header_opt.header_size,
+        m_coff_header_opt.sect_alignment,
----------------
jankratochvil wrote:
> dropped ///*file_size*///
somehow I thought that a non-trivial argument value does not need a comment, but you're right that this is still ambiguous. Adding it back.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69100/new/

https://reviews.llvm.org/D69100