[Lldb-commits] [PATCH] D67793: new api class: SBFile

[Lawrence D'Anna via Phabricator via lldb-commits]

lawrence_danna added a comment.

In D67793#1692544 <https://reviews.llvm.org/D67793#1692544>, @labath wrote:

> BTW, I've had to add (or rather, extend) a fairly ugly hack in r373573 in order to get the new tests running on non-darwin platforms. The reason for that is that the FILE* out typemap needs to get the "mode" of the object in order to construct the python wrapper.
>
> My hope is that we can be improved once you're finished your work here. For instance by reimplementing `GetOutputFileHandle` on top of `GetOutputFile` in swig, as the latter will (hopefully) be able to get the mode of a file correctly. Does that sound reasonable, or am I totally off-track here?


oops, sorry I missed this.   Are you happy with how it all turned out?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67793/new/

https://reviews.llvm.org/D67793