[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

[Vedant Kumar via Phabricator via lldb-commits]

vsk created this revision.
vsk added reviewers: jfb, nickdesaulniers, friss, JDevlieghere.
Herald added subscribers: dexonsmith, hiraditya, mgorny.
Herald added a project: LLVM.

Occasionally, during test teardown, there is a write to a closed pipe in of
LLDB's handful of IPC channels. Sometimes the communication is inherently
unreliable, so LLDB tries to avoid being killed due to SIGPIPE. Actually, it
explicitly calls `signal(SIGPIPE, SIG_IGN)`.  However, LLVM's default SIGPIPE
behavior is to exit with IO_ERR. Opt LLDB out of that.

I expect that this will resolve some LLDB test suite flakiness (tests
randomly failing with IO_ERR) that we've seen since r344372.

rdar://55750240


https://reviews.llvm.org/D69148

Files:
  lldb/tools/driver/Driver.cpp
  llvm/include/llvm/Support/Signals.h
  llvm/lib/Support/Unix/Signals.inc
  llvm/lib/Support/Windows/Signals.inc
  llvm/unittests/Support/CMakeLists.txt
  llvm/unittests/Support/SignalsTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69148.225541.patch
Type: text/x-patch
Size: 5695 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191017/7a455206/attachment-0001.bin>