[Lldb-commits] [lldb] r375173 - [lldb] X-fail tests that use constructors in expressions on Windows

[Raphael Isemann via lldb-commits]

Author: teemperor
Date: Thu Oct 17 14:27:26 2019
New Revision: 375173

URL: http://llvm.org/viewvc/llvm-project?rev=375173&view=rev
Log:
[lldb] X-fail tests that use constructors in expressions on Windows

These tests were testing a bug related to constructors. It seems that
on Windows the expression command can't construct objects (or at least,
call their constructor explicitly which is required for the tests), so
this is just x-failing them until Windows actually supports constructor calls.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py
    lldb/trunk/packages/Python/lldbsuite/test/commands/expression/ignore-artificial-constructors/TestIgnoreArtificialConstructors.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py?rev=375173&r1=375172&r2=375173&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py Thu Oct 17 14:27:26 2019
@@ -53,3 +53,20 @@ class ExprCommandCallOverriddenMethod(Te
         # Test with locally constructed instances.
         self.expect("expr Base().foo()", substrs=["1"])
         self.expect("expr Derived().foo()", substrs=["2"])
+
+    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr43707")
+    def test_call_on_temporary(self):
+        """Test calls to overridden methods in derived classes."""
+        self.build()
+
+        # Set breakpoint in main and run exe
+        self.runCmd("file " + self.getBuildArtifact("a.out"),
+                    CURRENT_EXECUTABLE_SET)
+        lldbutil.run_break_set_by_file_and_line(
+            self, "main.cpp", self.line, num_expected_locations=-1, loc_exact=True)
+
+        self.runCmd("run", RUN_SUCCEEDED)
+
+        # Test with locally constructed instances.
+        self.expect("expr Base().foo()", substrs=["1"])
+        self.expect("expr Derived().foo()", substrs=["2"])

Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/expression/ignore-artificial-constructors/TestIgnoreArtificialConstructors.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/commands/expression/ignore-artificial-constructors/TestIgnoreArtificialConstructors.py?rev=375173&r1=375172&r2=375173&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/commands/expression/ignore-artificial-constructors/TestIgnoreArtificialConstructors.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/commands/expression/ignore-artificial-constructors/TestIgnoreArtificialConstructors.py Thu Oct 17 14:27:26 2019
@@ -1,4 +1,5 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-lldbinline.MakeInlineTest(__file__, globals(), None)
+lldbinline.MakeInlineTest(__file__, globals(), [lldbinline.expectedFailureAll(
+            oslist=["windows"], bugnumber="llvm.org/pr43707")])