[Lldb-commits] [PATCH] D69106: MemoryRegion: Print "don't know" permission values as such

Thu Oct 17 08:17:33 PDT 2019

clayborg added a comment.

Looks good. Do we maybe want to use "unknown" instead of "don't know" when printing out the long for of a MemoryRegionInfo::OptionalBool? Or maybe "???"?

================
Comment at: test/Shell/Minidump/memory-region-from-module.yaml:22
 # CHECK1: [0x0000000000004000-0x00000000000040b0) r-x {{.*}}memory-region-from-module.exe PT_LOAD[0]
-# TODO: This output does not give any indication that the region is only "potentially" writable.
-# CHECK2: [0x0000000000004000-0x0000000000004010) rwx
+# CHECK2: [0x0000000000004000-0x0000000000004010) r??
 # ALL-LABEL: (lldb) memory region 0x5000
----------------
How do we get two responses for a single address here?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69106/new/

https://reviews.llvm.org/D69106