[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

Wed Oct 16 04:29:16 PDT 2019

labath added a comment.

Looks pretty good, just two quick comments.

================
Comment at: lldb/packages/Python/lldbsuite/test/commands/platform/process/TestProcessList.py:15-17
+exe_name = "TestProcess"  # Must match Makefile
+
+
----------------
You don't need this. This was present in the other test because it was (also) attaching by name, but when attaching by pid, you can do with the default "a.out".

================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1941
+            process_info.GetArguments().Clear();
+            process_info.SetArg0(" ");
+            break;
----------------
Why a single space? I can understand an empty string, but a `" "` seems very arbitrary...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68293/new/

https://reviews.llvm.org/D68293