[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/docs/lldb-gdb-remote.txt:1456
+//                          separated by the character '-', where each argument is
+//                          hex-encoded.
 //
----------------
Does that include argv[0]? I take it does, but argv[0] is funny, so it's better to be explicit about that.


================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py:63-66
+            self.assertRaises(
+                Exception,
+                lambda : self.expect("platform process list -xv", substrs=["/system/bin/ls"])
+            )
----------------
Is this a negative check? We usually use `expect(..., error=True)` for that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68293/new/

https://reviews.llvm.org/D68293