[Lldb-commits] [PATCH] D68962: update ScriptInterpreterPython to use File, not FILE*

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 15 00:48:12 PDT 2019


labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Core/Debugger.cpp:977
+  if (!in || !in->IsValid()) {
+    in.reset();
     if (top_reader_sp)
----------------
The call to reset seems superfluous, as the value will be overwritten anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68962/new/

https://reviews.llvm.org/D68962





More information about the lldb-commits mailing list