[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

Mon Oct 14 22:34:16 PDT 2019

hhb marked 3 inline comments as done.
hhb added inline comments.

================
Comment at: lldb/CMakeLists.txt:244
+  else()
+    set(LIBLLDB_SYMLINK_DEST "${liblldb_build_dir}/liblldb${CMAKE_SHARED_LIBRARY_SUFFIX}")
+  endif()
----------------
tatyana-krasnukha wrote:
> This command still produces a path without configuration name, Visual Studio failed to execute the post-build step.
> 
Thanks for testing and the patch! I found that CMAKE_CFG_INTDIR can actually be passed into function and expanded to $(Configure). At least in VS2019 community... Can you try this new version? Thanks again!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68858/new/

https://reviews.llvm.org/D68858