[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

[Aleksandr Urakov via lldb-commits]

Sorry, I'm OOO now. I'll take a look tomorrow, thanks for catching that!

On Mon, 14 Oct 2019, 19:20 Stella Stamenova via Phabricator, <
reviews at reviews.llvm.org> wrote:

> stella.stamenova added a comment.
>
> In D67347#1706405 <https://reviews.llvm.org/D67347#1706405>,
> @stella.stamenova wrote:
>
> > It looks like this changed fixed at least one of the XFAILed tests on
> Windows:
> >
> > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9751
> >
> > So now the test results would be red because of the unexpectedly passing
> test (if there wasn't another failure). Could you have a look at whether
> any of the other tests that were XFAILed for the same bug are also now
> passing and remove the expected failure tags as appropriate?
>
>
> This is still "failing" on the windows bot. Please fix the issue or revert
> the change.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D67347/new/
>
> https://reviews.llvm.org/D67347
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191014/1db26cf0/attachment.html>