[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

[Konrad Wilhelm Kleine via Phabricator via lldb-commits]

kwk added a comment.

In D68943#1708068 <https://reviews.llvm.org/D68943#1708068>, @MaskRay wrote:

> This is not correct. A lot of yaml2obj tests fail with:
>
> > yaml2obj: error: unknown section referenced: '.symtab' by YAML section '.rela.text'


@MaskRay I'm so sorry. You're absolutely right. I was working only in LLDB for the last months and used `check-lldb` only. That's probably because I missed those errors.

> The problem is that .symtab can be the sh_link field of relocation sections, .llvm_addrsig, and some sections that may be added in the future.
> 
> Making .symtab conditionally define is difficult. I'll take a closer look tomorrow.

Thank you. Meanwhile I will run more tests to see what exactly fails.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68943/new/

https://reviews.llvm.org/D68943