[Lldb-commits] [PATCH] D68939: [LLDB] [PECOFF] Use a "pc" vendor name in aarch64 triples

Mon Oct 14 06:24:40 PDT 2019

mstorsjo added a comment.

In D68939#1707985 <https://reviews.llvm.org/D68939#1707985>, @labath wrote:

> Would you say that "pc" is a reasonable value for the "vendor" field for the win+aarch64 combo? I am asking because I don't have a clue about that, and given that this platform is being brought up right now, changing this now would be way easier than doing it later. (The reason why things don't work is the incompatibility between the two things that compute the ArchSpec, but that can also be fixed by changing the other mechanism, if that is better/more correct.) My guess is the other mechanism is ArchSpec::SetArchitecture function, line 928...

I'd say "pc" is fine here; such machines are available for sale (although with a bit scarce availability) as normal power efficient laptops - google for e.g. HP Envy X2, for one that is available with both arm and x86 cpu options.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68939/new/

https://reviews.llvm.org/D68939