[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Oct 14 01:33:00 PDT 2019
labath added inline comments.
================
Comment at: lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py:31
+ # which is not necessarily the order on the screen.)
+ self.child.timeout = 2
+ self.child.send("s") # step
----------------
What's the reason for that? It'd be best to not mess with the timeout in the test, and particularly to not set such a small time out as it will likely lead to flakyness on slow/heavily loaded machines.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68541/new/
https://reviews.llvm.org/D68541
More information about the lldb-commits
mailing list