[Lldb-commits] [lldb] r374616 - Temporarily Revert [platform process list] add a flag for showing the processes of all users
Adrian Prantl via lldb-commits
lldb-commits at lists.llvm.org
Fri Oct 11 17:03:41 PDT 2019
Author: adrian
Date: Fri Oct 11 17:03:40 2019
New Revision: 374616
URL: http://llvm.org/viewvc/llvm-project?rev=374616&view=rev
Log:
Temporarily Revert [platform process list] add a flag for showing the processes of all users
as it breaks the bots.
This reverts r374609 (git commit 696d3cf8ad6f3a0b3019c87526d561bb77ad538e)
Removed:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py
lldb/trunk/source/Commands/CommandObjectPlatform.cpp
lldb/trunk/source/Commands/Options.td
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
Removed: lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py?rev=374615&view=auto
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py (removed)
@@ -1,39 +0,0 @@
-import lldb
-import binascii
-import os
-from lldbsuite.test.lldbtest import *
-from lldbsuite.test.decorators import *
-from gdbclientutils import *
-
-
-class TestPlatformClient(GDBRemoteTestBase):
-
- def test_process_list_with_all_users(self):
- """Test connecting to a remote linux platform"""
-
- class MyResponder(MockGDBServerResponder):
- def qfProcessInfo(self, packet):
- if "all_users:1" in packet:
- return "pid:10;ppid:1;uid:1;gid:1;euid:1;egid:1;name:" + binascii.hexlify("/a/test_process") + ";"
- else:
- return "E04"
-
- self.server.responder = MyResponder()
-
- self.runCmd("log enable gdb-remote all")
- self.runCmd("platform select remote-linux")
-
- try:
- url = "connect://localhost:%d" % self.server.port
-
- #self.gdb.GetSelectedPlatform().ConnectRemote(lldb.SBPlatformConnectOptions(url))
- self.runCmd("platform connect connect://localhost:%d" %
- self.server.port)
- self.assertTrue(self.dbg.GetSelectedPlatform().IsConnected())
- self.expect("platform process list -x",
- substrs=["1 matching process was found", "test_process"])
- self.expect("platform process list",
- error=True,
- substrs=["error: no processes were found on the \"remote-linux\" platform"])
- finally:
- self.dbg.GetSelectedPlatform().DisconnectRemote()
Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py?rev=374616&r1=374615&r2=374616&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py Fri Oct 11 17:03:40 2019
@@ -160,34 +160,9 @@ class MockGDBServerResponder:
return self.QListThreadsInStopReply()
if packet.startswith("qMemoryRegionInfo:"):
return self.qMemoryRegionInfo()
- if packet == "qQueryGDBServer":
- return self.qQueryGDBServer()
- if packet == "qHostInfo":
- return self.qHostInfo()
- if packet == "qGetWorkingDir":
- return self.qGetWorkingDir()
- if packet == "qsProcessInfo":
- return self.qsProcessInfo()
- if packet.startswith("qfProcessInfo"):
- return self.qfProcessInfo(packet)
return self.other(packet)
- def qsProcessInfo(self):
- return "E04"
-
- def qfProcessInfo(self, packet):
- raise "E04"
-
- def qGetWorkingDir(self):
- return "2f"
-
- def qHostInfo(self):
- return "ptrsize:8;endian:little;"
-
- def qQueryGDBServer(self):
- return "E04"
-
def interrupt(self):
raise self.UnexpectedPacketException()
@@ -196,7 +171,7 @@ class MockGDBServerResponder:
def vCont(self, packet):
raise self.UnexpectedPacketException()
-
+
def readRegisters(self):
return "00000000" * self.registerCount
@@ -450,6 +425,7 @@ class MockGDBServer:
class InvalidPacketException(Exception):
pass
+
class GDBRemoteTestBase(TestBase):
"""
Base class for GDB client tests.
Modified: lldb/trunk/source/Commands/CommandObjectPlatform.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectPlatform.cpp?rev=374616&r1=374615&r2=374616&view=diff
==============================================================================
--- lldb/trunk/source/Commands/CommandObjectPlatform.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectPlatform.cpp Fri Oct 11 17:03:40 2019
@@ -1264,10 +1264,6 @@ protected:
verbose = true;
break;
- case 'x':
- match_info.SetMatchAllUsers(true);
- break;
-
default:
llvm_unreachable("Unimplemented option");
}
Modified: lldb/trunk/source/Commands/Options.td
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/Options.td?rev=374616&r1=374615&r2=374616&view=diff
==============================================================================
--- lldb/trunk/source/Commands/Options.td (original)
+++ lldb/trunk/source/Commands/Options.td Fri Oct 11 17:03:40 2019
@@ -591,9 +591,6 @@ let Command = "platform process list" in
def platform_process_list_show_args : Option<"show-args", "A">,
GroupRange<1, 6>,
Desc<"Show process arguments instead of the process executable basename.">;
- def platform_process_list_all_users: Option<"all-users", "x">,
- GroupRange<1,6>,
- Desc<"Show processes matching all user IDs.">;
def platform_process_list_verbose : Option<"verbose", "v">, GroupRange<1, 6>,
Desc<"Enable verbose output.">;
}
Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp?rev=374616&r1=374615&r2=374616&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp Fri Oct 11 17:03:40 2019
@@ -2176,7 +2176,8 @@ uint32_t GDBRemoteCommunicationClient::F
if (match_info.GetProcessInfo().EffectiveGroupIDIsValid())
packet.Printf("egid:%u;",
match_info.GetProcessInfo().GetEffectiveGroupID());
- packet.Printf("all_users:%u;", match_info.GetMatchAllUsers() ? 1 : 0);
+ if (match_info.GetProcessInfo().EffectiveGroupIDIsValid())
+ packet.Printf("all_users:%u;", match_info.GetMatchAllUsers() ? 1 : 0);
if (match_info.GetProcessInfo().GetArchitecture().IsValid()) {
const ArchSpec &match_arch =
match_info.GetProcessInfo().GetArchitecture();
More information about the lldb-commits
mailing list