[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

[Joseph Tremoulet via Phabricator via lldb-commits]

JosephTremoulet updated this revision to Diff 224607.
JosephTremoulet added a comment.

  Address review feedback
  
    - Add Exception stream to minidump-basic.yaml to test obj2yaml
      direction
    - Reorder ExceptionStream definition and constructors
    - Use the mapOptional helper
    - Replace "Number Parameters" with "Number of Parameters" in YAML
    - Stop using mapping traits validation for number of parameters,
      update test to ensure correctly de-yamlizing an exception record
      with an out-of-bounds number of parameters


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68657/new/

https://reviews.llvm.org/D68657

Files:
  lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-x86_64.yaml
  llvm/include/llvm/ObjectYAML/MinidumpYAML.h
  llvm/lib/ObjectYAML/MinidumpEmitter.cpp
  llvm/lib/ObjectYAML/MinidumpYAML.cpp
  llvm/test/tools/obj2yaml/basic-minidump.yaml
  llvm/unittests/ObjectYAML/MinidumpYAMLTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68657.224607.patch
Type: text/x-patch
Size: 19333 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191011/b5669c9b/attachment-0001.bin>