[Lldb-commits] [PATCH] D68770: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo added a comment.

In D68770#1704663 <https://reviews.llvm.org/D68770#1704663>, @amccarth wrote:

> Cool.  I didn't know about InitLLVM.  That makes things much cleaner.
>
> Though I do recall recently seeing another complaint about `argv[0]` not being preserved as typed but being replaced by an absolute path.  That will definitely happen now on Windows.  Is that a problem?


I remember seeing such behaviour elsewhere (clang) as well. I don't think that InitLLVM does any such rewrite of argv[0] though, so this patch should pretty much be a plain refactoring.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68770/new/

https://reviews.llvm.org/D68770