[Lldb-commits] [PATCH] D68812: [test] Pass DSYMUTIL and SDKROOT as part of the make invocation.

Thu Oct 10 10:53:09 PDT 2019

clayborg added a comment.

In D68812#1704275 <https://reviews.llvm.org/D68812#1704275>, @JDevlieghere wrote:

> In D68812#1704235 <https://reviews.llvm.org/D68812#1704235>, @clayborg wrote:
>
> > It would be great if we could ensure that if a test fails, that the "dotest" command line text has everything it needs as well, including the options and paths to lldb, framework, shared library and other settings. If I "ninja check-lldb", I have to manually insert many arguments before the command the FAIL file says to run will work.
>
>
> Any reason you want to run dotest.py directly? If you use `bin/lldb-dotest` you'll get all dotest arguments that CMake configuration. Even better is to use `lit --filter <name of test to rerun>`, which guarantees that you'll have the exact same dotest.py invocation as during `check-ldlb`.

it is mainly because that is what the FAIL file for the test run specifies to run. Not sure if that is fixed yet, but that is my ask here was that we fix the code that says "run this command to reproduce this test", which last I checked, was saying to run dotest.py directly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68812/new/

https://reviews.llvm.org/D68812