[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Oct 9 15:05:11 PDT 2019
clayborg added inline comments.
================
Comment at: lldb/include/lldb/API/SBDebugger.h:97-102
+ SBError SetInputFile(FileSP file);
+
+ SBError SetOutputFile(FileSP file);
+
+ SBError SetErrorFile(FileSP file);
+
----------------
Are these really for public consumption? I would hope not, and might add then as protected and friend in any code that needs to use them? At the very least a comment specifying these are for internal use. Does SBFile not have a way to construct with a FileSP? Maybe these are not needed if that is the case?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68734/new/
https://reviews.llvm.org/D68734
More information about the lldb-commits
mailing list