[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

Wed Oct 9 14:52:18 PDT 2019

clayborg added a comment.

That qualified name hash the Apple tables used to avoid pulling in DWARF for stuff that didn't match. Did this functionality stop working when accelerator tables got refactored? The .apple_types has a qualified name hash which is the hash of the complete type named (demangled).

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:114
+
+  // When searching for "std::vector<int>::const_iterator", reject any
+  // files without "vector<int>" early, since there will be many other
----------------
The "qualified_name_hash" used to avoid pulling in all DWARF for anything that didn't match. Is this not working anymore?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68678/new/

https://reviews.llvm.org/D68678