[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

My hope was that something like -find=variable -dump-clang-ast would make sense at least from a theoretical perspective. However, after reading to source code, it looks like that may not be true as (I think) we don't actually create ast nodes for variables. So, making this option a sort of a "top-level" thing may be the best thing to do. Given that now the "symbols" subcommand has a fair set of options, all of which are mutually incompatible (-verify, --dump-ast, -dump-clang-ast, the "default" mode), I think it might make sense to create new subcommands for each of these "modes" ("lldb-test symbols ast") so that they can each get their own options, independently of the others. However, I don't want to hold up other progress over that...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67994/new/

https://reviews.llvm.org/D67994