[Lldb-commits] [PATCH] D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

I have no memory of adding the 'addr' parameter.

If you had a search that was guaranteed to only return one address per invocation, this would allow you to have the searcher coordinate gathering the results, rather than having the callback record them on its own.  That might be another convenient usage pattern, but if we really wanted to do that we should have passed in a vector of addresses, since it seems hard to guarantee one-match per invocation.  Since we've never actually wanted to handle searches this way, it seems fine to remove this parameter.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68696/new/

https://reviews.llvm.org/D68696