[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lib/ObjectYAML/MinidumpEmitter.cpp:166
+    Header.SizeOfEntry = sizeof(minidump::MemoryInfo);
+    Header.NumberOfEntries = InfoList.Infos.size();
+    File.allocateNewObject<minidump::MemoryInfoListHeader>(Header);
----------------
grimar wrote:
> Probably just
> 
> ```
>     minidump::MemoryInfoListHeader Header = {
>         (support::ulittle32_t)sizeof(minidump::MemoryInfoListHeader),
>         (support::ulittle32_t)sizeof(minidump::MemoryInfo),
>         (support::ulittle64_t)InfoList.Infos.size()};
> ```
> 
> ?
> 
> Or perhaps it could have a constructor.
The thought of a constructor has crossed my mind too. I've now added it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68645/new/

https://reviews.llvm.org/D68645