[Lldb-commits] [lldb] r374121 - Revert Trust the arange accelerator tables in dSYMs

[Adrian Prantl via lldb-commits]

Author: adrian
Date: Tue Oct  8 14:34:22 2019
New Revision: 374121

URL: http://llvm.org/viewvc/llvm-project?rev=374121&view=rev
Log:
Revert Trust the arange accelerator tables in dSYMs

This reverts r374117 (git commit 6399db2f6fd64fa250093368be40eb5ae3af513b)
while inspecting bot breakage.

Modified:
    lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp?rev=374121&r1=374120&r2=374121&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp Tue Oct  8 14:34:22 2019
@@ -54,19 +54,13 @@ llvm::Expected<DWARFDebugAranges &> DWAR
 
   // Manually build arange data for everything that wasn't in the
   // .debug_aranges table.
-  //
-  // This step is skipped for dSYMs and other debug-info-only
-  // objects, which are always trusted to have a complete table.
-  auto *obj = m_dwarf.GetObjectFile();
-  if (!obj || obj->GetType() != ObjectFile::eTypeDebugInfo) {
-    const size_t num_units = GetNumUnits();
-    for (size_t idx = 0; idx < num_units; ++idx) {
-      DWARFUnit *cu = GetUnitAtIndex(idx);
+  const size_t num_units = GetNumUnits();
+  for (size_t idx = 0; idx < num_units; ++idx) {
+    DWARFUnit *cu = GetUnitAtIndex(idx);
 
-      dw_offset_t offset = cu->GetOffset();
-      if (cus_with_data.find(offset) == cus_with_data.end())
-        cu->BuildAddressRangeTable(m_cu_aranges_up.get());
-    }
+    dw_offset_t offset = cu->GetOffset();
+    if (cus_with_data.find(offset) == cus_with_data.end())
+      cu->BuildAddressRangeTable(m_cu_aranges_up.get());
   }
 
   const bool minimize = true;