[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 8 14:24:28 PDT 2019


amccarth accepted this revision.
amccarth added a comment.

LGTM after one question.



================
Comment at: lldb/lit/SymbolFile/PDB/udt-layout.test:1
 REQUIRES: system-windows, lld
 RUN: %build --compiler=clang-cl --output=%t.exe %S/Inputs/UdtLayoutTest.cpp
----------------
Is `system-windows` still required after you've removed the dependency on dbghelp?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68134/new/

https://reviews.llvm.org/D68134





More information about the lldb-commits mailing list