[Lldb-commits] [PATCH] D61886: Support member functions construction and lookup in PdbAstBuilder

[Adrian McCarthy via Phabricator via lldb-commits]

amccarth added a comment.
Herald added a subscriber: JDevlieghere.

Is this still an active review or has this been abandoned?



================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1047
+    function_decl = m_clang.CreateFunctionDeclaration(
       parent, proc_name.str().c_str(), func_ct, storage, false);
+  }
----------------
It looks like `CreateFunctionDeclaration` can fail (returning a null pointer).  Should this bail out if `function_decl` remains null pointer here (rather than crashing several lines later, after creating some bad mappings)?  Should we assert here to make debugging easier?

Also, nit, check the indentation here.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61886/new/

https://reviews.llvm.org/D61886