[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik accepted this revision.
shafik added a comment.

LGTM



================
Comment at: source/Plugins/Language/CPlusPlus/LibCxxBitset.cpp:34
   std::vector<ValueObjectSP> m_elements;
-  ValueObjectSP m_first;
+  ValueObject* m_first = nullptr;
   CompilerType m_bool_type;
----------------
I feel like each of these pointer members deserve a comment.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68641/new/

https://reviews.llvm.org/D68641