[Lldb-commits] [PATCH] D68647: Simplify LZMA decoding by using ArrayRef::take_back

[Konrad Wilhelm Kleine via Phabricator via lldb-commits]

kwk marked an inline comment as done.
kwk added inline comments.


================
Comment at: lldb/source/Host/common/LZMA.cpp:99
+      &xzindex, &memlimit, nullptr,
+      InputBuffer.take_back(LZMA_STREAM_HEADER_SIZE - opts.backward_size)
+          .data(),
----------------
labath wrote:
> I think this should be + to preserve semantics, though I am not sure why no tests fail because of that. I guess none of the lzma streams we have have non-zero `backward_size`..
Sorry, tests are still running... and you're right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68647/new/

https://reviews.llvm.org/D68647