[Lldb-commits] [PATCH] D68638: [lldb] Avoid resource leak
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Oct 8 07:19:52 PDT 2019
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM. Also, this whole function seems to have no tests. So if you find an easy way to test this, then please add a test to `functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py`. You can also check this in as-is if the test turns out to be too complicated (I'm not a big fan of the whole "you touched my spaghetti so you also have to come up with a way to test the whole thing".)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68638/new/
https://reviews.llvm.org/D68638
More information about the lldb-commits
mailing list