[Lldb-commits] [PATCH] D68631: ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested, take 2

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: JDevlieghere, teemperor, jingham.

The previous attempt at making nameless process not match when searching for a
given name failed because the macos implementation was depending on this detail
in its partial matching strategy. Doing partial matching to avoid expensive
lookups is a perfectly valid thing to do, the way it was implemented seems
somewhat unexpected.

This patch implements it differently by providing special
methods in the ProcessInstanceInfoMatch which match only a subset of fields,
and changes mac host code to use those instead.

Then, it re-applies r373925 to get make the ProcessInstanceInfoMatch with a
name *not* match a nameless process.


https://reviews.llvm.org/D68631

Files:
  include/lldb/Utility/ProcessInfo.h
  source/Host/macosx/objcxx/Host.mm
  source/Utility/ProcessInfo.cpp
  unittests/Utility/ProcessInstanceInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68631.223822.patch
Type: text/x-patch
Size: 5345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191008/1f6433e3/attachment.bin>