[Lldb-commits] [lldb] r374007 - test fix: TestLoadUsingPaths should use realpath
Lawrence D'Anna via lldb-commits
lldb-commits at lists.llvm.org
Mon Oct 7 18:16:29 PDT 2019
Author: lawrence_danna
Date: Mon Oct 7 18:16:29 2019
New Revision: 374007
URL: http://llvm.org/viewvc/llvm-project?rev=374007&view=rev
Log:
test fix: TestLoadUsingPaths should use realpath
Summary:
TestLoadUsingPaths will fail if the build directory has
symlinks in its path, because the real paths reported by
the debugger won't match the symlink-laden paths it's expecting.
This can be solved just by using os.path.realpath on the base
path for the test.
Reviewers: JDevlieghere, jasonmolenda, labath
Reviewed By: JDevlieghere
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D68618
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_using_paths/TestLoadUsingPaths.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_using_paths/TestLoadUsingPaths.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_using_paths/TestLoadUsingPaths.py?rev=374007&r1=374006&r2=374007&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_using_paths/TestLoadUsingPaths.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_using_paths/TestLoadUsingPaths.py Mon Oct 7 18:16:29 2019
@@ -33,7 +33,7 @@ class LoadUsingPathsTestCase(TestBase):
ext = 'dylib'
self.lib_name = 'libloadunload.' + ext
- self.wd = self.getBuildDir()
+ self.wd = os.path.realpath(self.getBuildDir())
self.hidden_dir = os.path.join(self.wd, 'hidden')
self.hidden_lib = os.path.join(self.hidden_dir, self.lib_name)
More information about the lldb-commits
mailing list