[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/API/SBCommandReturnObject.cpp:296
+                     (FileSP), file_sp);
+  return SetImmediateOutputFile(SBFile(file_sp));
+}
----------------
I'd drop the return.


================
Comment at: lldb/source/API/SBCommandReturnObject.cpp:302
+                     (FileSP), file_sp);
+  return SetImmediateErrorFile(SBFile(file_sp));
 }
----------------
Same here 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68434/new/

https://reviews.llvm.org/D68434