[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

[Frederic Riss via Phabricator via lldb-commits]

friss marked an inline comment as done.
friss added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:771
 else
-	$(RM) "$(EXE)"
+	$(RM) -r $(wildcard $(BUILDDIR)/*)
 endif
----------------
aprantl wrote:
> I would just error, period. IMHO `make clean` shouldn'd delete anything that `make` doesn't know how to rebuild and I don't think we have any rule to restore `$(BUILDDIR)`, do we?
We don't delete $(BUILDDIR), we delete what's inside of it. I would have gotten rid of the rule completely, but having a `clean` rule is handy in one circumstance:  when iterating over the build of a new test (or like I did last week rework a lot of existing test builds). There you want to be able to run the make command by itself, and being able to quickly iterate with `make clean all` is really nice. I don't think we're taking any risk here as the rule checks whether we are inside a directory that dotest is going to wipe anyway.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68558/new/

https://reviews.llvm.org/D68558