[Lldb-commits] [PATCH] D68536: [MachO] Fix symbol merging during symtab parsing.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:3695
+                                 bool debug_only) {
+      const bool is_debug = ((nlist.n_type & N_STAB) != 0);
+      if (is_debug != debug_only)
----------------
labath wrote:
> Personally, I'd just move this check out of the lambda and into the code which invokes it.
Given that you need is_debug all throughout the parsing code I'm not convinced that'd be an improvement. Either you'd have to compute it twice or you'd have to pass it in which case you still have the extra argument. 


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68536/new/

https://reviews.llvm.org/D68536