[Lldb-commits] [PATCH] D68366: Parametrize scripted ThreadPlans using SBStructuredData

[Jim Ingham via Phabricator via lldb-commits]

jingham marked 4 inline comments as done.
jingham added inline comments.


================
Comment at: lldb/include/lldb/Target/ThreadPlanPython.h:35
+  ThreadPlanPython(Thread &thread, const char *class_name, 
+                   StructuredDataImpl *args_data);
   ~ThreadPlanPython() override;
----------------
JDevlieghere wrote:
> Why do we need the StructuredDataImpl and not the StructuredData?
I figured out that I had to do it this way when I implemented the same feature as part of the ScriptedBreakpointResolvers.  This change is largely copied from that.  But I don't remember why now.  

I'll go back and figure that out again if you are really curious, but since this is following a successful precedent, I'd rather not do that right now...


================
Comment at: lldb/source/API/SBThreadPlan.cpp:409
+
+  if (m_opaque_sp) {
+    Status plan_status;
----------------
JDevlieghere wrote:
> Swap this and have an early return?
Every other function in this file is written this way.  I don't want to fix them piecemeal, and doing them all here would make this commit too hard to read.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68366/new/

https://reviews.llvm.org/D68366