[Lldb-commits] [PATCH] D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: clang/include/clang/AST/ExternalASTMerger.h:87
     const OriginMap &OM;
+    /// True iff the source only exists temporary, i.e. it will be removed from
+    /// the ExternalASTMerger during the life time of the ExternalASTMerger.
----------------
super-nit: there's supposed to be a comma before and after "i.e." and "e.g." :-)


================
Comment at: clang/lib/AST/ExternalASTMerger.cpp:171
+    // Check that we never end up in the current Importer again.
+    assert(&PersistentCtx != &getFromContext());
+    assert(&OtherImporter != this);
----------------
&& "error message" ... this will help with debugging in a couple of months!


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68326/new/

https://reviews.llvm.org/D68326